Commit aafc917a authored by Ricardo Neri's avatar Ricardo Neri Committed by Peter Zijlstra
Browse files

sched/fair: Carve out logic to mark a group for asymmetric packing 



Create a separate function, sched_asym(). A subsequent changeset will
introduce logic to deal with SMT in conjunction with asmymmetric
packing. Such logic will need the statistics of the scheduling
group provided as argument. Update them before calling sched_asym().

Co-developed-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarRicardo Neri <ricardo.neri-calderon@linux.intel.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
Reviewed-by: default avatarLen Brown <len.brown@intel.com>
Reviewed-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Link: https://lkml.kernel.org/r/20210911011819.12184-6-ricardo.neri-calderon@linux.intel.com
parent c0d14b57

kernel/sched/fair.c

+13 −7
Original line number Diff line number Diff line
@@ -8571,6 +8571,13 @@ group_type group_classify(unsigned int imbalance_pct, 
	return group_has_spare;

}



static inline bool

sched_asym(struct lb_env *env, struct sd_lb_stats *sds,  struct sg_lb_stats *sgs,

	   struct sched_group *group)

{

	return sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu);

}



/**

 * update_sg_lb_stats - Update sched_group's statistics for load balancing.

 * @env: The load balancing environment.
@@ -8631,18 +8638,17 @@ static inline void update_sg_lb_stats(struct lb_env *env, 
		}

	}



	sgs->group_capacity = group->sgc->capacity;



	sgs->group_weight = group->group_weight;



	/* Check if dst CPU is idle and preferred to this group */

	if (!local_group && env->sd->flags & SD_ASYM_PACKING &&

	    env->idle != CPU_NOT_IDLE &&

	    sgs->sum_h_nr_running &&

	    sched_asym_prefer(env->dst_cpu, group->asym_prefer_cpu)) {

	    env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running &&

	    sched_asym(env, sds, sgs, group)) {

		sgs->group_asym_packing = 1;

	}



	sgs->group_capacity = group->sgc->capacity;



	sgs->group_weight = group->group_weight;



	sgs->group_type = group_classify(env->sd->imbalance_pct, group, sgs);



	/* Computing avg_load makes sense only when group is overloaded */