Commit c0d14b57 authored by Ricardo Neri's avatar Ricardo Neri Committed by Peter Zijlstra
Browse files

sched/fair: Provide update_sg_lb_stats() with sched domain statistics 



Before deciding to pull tasks when using asymmetric packing of tasks,
on some architectures (e.g., x86) it is necessary to know not only the
state of dst_cpu but also of its SMT siblings. The decision to classify
a candidate busiest group as group_asym_packing is done in
update_sg_lb_stats(). Give this function access to the scheduling domain
statistics, which contains the statistics of the local group.

Originally-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarRicardo Neri <ricardo.neri-calderon@linux.intel.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarJoel Fernandes (Google) <joel@joelfernandes.org>
Reviewed-by: default avatarLen Brown <len.brown@intel.com>
Reviewed-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Link: https://lkml.kernel.org/r/20210911011819.12184-5-ricardo.neri-calderon@linux.intel.com
parent 60256435

kernel/sched/fair.c

+3 −2
Original line number Diff line number Diff line
@@ -8579,6 +8579,7 @@ group_type group_classify(unsigned int imbalance_pct, 
 * @sg_status: Holds flag indicating the status of the sched_group

 */

static inline void update_sg_lb_stats(struct lb_env *env,

				      struct sd_lb_stats *sds,

				      struct sched_group *group,

				      struct sg_lb_stats *sgs,

				      int *sg_status)
@@ -8587,7 +8588,7 @@ static inline void update_sg_lb_stats(struct lb_env *env, 


	memset(sgs, 0, sizeof(*sgs));



	local_group = cpumask_test_cpu(env->dst_cpu, sched_group_span(group));

	local_group = group == sds->local;



	for_each_cpu_and(i, sched_group_span(group), env->cpus) {

		struct rq *rq = cpu_rq(i);
@@ -9150,7 +9151,7 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd 
				update_group_capacity(env->sd, env->dst_cpu);

		}



		update_sg_lb_stats(env, sg, sgs, &sg_status);

		update_sg_lb_stats(env, sds, sg, sgs, &sg_status);



		if (local_group)

			goto next_group;