Commit aad0a80c authored by Rishabh Bhatnagar's avatar Rishabh Bhatnagar Committed by sanglipeng
Browse files

KVM: x86: revalidate steal time cache if MSR value changes

stable inclusion
from stable-v5.10.180
commit 4bffae22bec7e035e9d5a0c0db7286b6bd258f56
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I8FC2O

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=4bffae22bec7e035e9d5a0c0db7286b6bd258f56



--------------------------------

From: Paolo Bonzini <pbonzini@redhat.com>

commit 901d3765 upstream.

Commit 7e2175eb ("KVM: x86: Fix recording of guest steal time
/ preempted status", 2021-11-11) open coded the previous call to
kvm_map_gfn, but in doing so it dropped the comparison between the cached
guest physical address and the one in the MSR.  This cause an incorrect
cache hit if the guest modifies the steal time address while the memslots
remain the same.  This can happen with kexec, in which case the steal
time data is written at the address used by the old kernel instead of
the old one.

While at it, rename the variable from gfn to gpa since it is a plain
physical address and not a right-shifted one.

Reported-by: default avatarDave Young <ruyang@redhat.com>
Reported-by: default avatarXiaoying Yan <yiyan@redhat.com>
Analyzed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
Cc: David Woodhouse <dwmw@amazon.co.uk>
Cc: stable@vger.kernel.org
Fixes: 7e2175eb ("KVM: x86: Fix recording of guest steal time / preempted status")
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarRishabh Bhatnagar <risbhat@amazon.com>
Tested-by: default avatarAllen Pais <apais@linux.microsoft.com>
Acked-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarsanglipeng <sanglipeng1@jd.com>
parent 4c200652
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment