Commit a91c99b1 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: gadget: bcm63xx_udc: fix memory leak with using debugfs_lookup() 

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Kevin Cernekee <cernekee@gmail.com>
Link: https://lore.kernel.org/r/20230202153235.2412790-9-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 73f44513

drivers/usb/gadget/udc/bcm63xx_udc.c

+1 −1
Original line number Diff line number Diff line
@@ -2253,7 +2253,7 @@ static void bcm63xx_udc_init_debugfs(struct bcm63xx_udc *udc) 
 */

static void bcm63xx_udc_cleanup_debugfs(struct bcm63xx_udc *udc)

{

	debugfs_remove(debugfs_lookup(udc->gadget.name, usb_debug_root));

	debugfs_lookup_and_remove(udc->gadget.name, usb_debug_root);

}



/***********************************************************************