Commit 73f44513 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

USB: gadget: gr_udc: fix memory leak with using debugfs_lookup() 

When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Jakob Koschel <jakobkoschel@gmail.com>
Link: https://lore.kernel.org/r/20230202153235.2412790-8-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c26e682a

drivers/usb/gadget/udc/gr_udc.c

+1 −1
Original line number Diff line number Diff line
@@ -215,7 +215,7 @@ static void gr_dfs_create(struct gr_udc *dev) 


static void gr_dfs_delete(struct gr_udc *dev)

{

	debugfs_remove(debugfs_lookup(dev_name(dev->dev), usb_debug_root));

	debugfs_lookup_and_remove(dev_name(dev->dev), usb_debug_root);

}



#else /* !CONFIG_USB_GADGET_DEBUG_FS */