Commit a806f67f authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

usb: musb: cppi41: Switch to use dev_err_probe() helper 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220927072616.913672-4-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 92150ca6

drivers/usb/musb/musb_cppi41.c

+2 −4
Original line number Diff line number Diff line
@@ -718,10 +718,8 @@ static int cppi41_dma_controller_start(struct cppi41_dma_controller *controller) 


		dc = dma_request_chan(dev->parent, str);

		if (IS_ERR(dc)) {

			ret = PTR_ERR(dc);

			if (ret != -EPROBE_DEFER)

				dev_err(dev, "Failed to request %s: %d.\n",

					str, ret);

			ret = dev_err_probe(dev, PTR_ERR(dc),

					    "Failed to request %s.\n", str);

			goto err;

		}