Commit 92150ca6 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

usb: musb: da8xx: Switch to use dev_err_probe() helper 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220927072616.913672-3-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7be7231d

drivers/usb/musb/da8xx.c

+3 −5
Original line number Diff line number Diff line
@@ -523,11 +523,9 @@ static int da8xx_probe(struct platform_device *pdev) 
	}



	glue->phy = devm_phy_get(&pdev->dev, "usb-phy");

	if (IS_ERR(glue->phy)) {

		if (PTR_ERR(glue->phy) != -EPROBE_DEFER)

			dev_err(&pdev->dev, "failed to get phy\n");

		return PTR_ERR(glue->phy);

	}

	if (IS_ERR(glue->phy))

		return dev_err_probe(&pdev->dev, PTR_ERR(glue->phy),

				     "failed to get phy\n");



	glue->dev			= &pdev->dev;

	glue->clk			= clk;