Unverified Commit a590370d authored by Roman Guskov's avatar Roman Guskov Committed by Mark Brown
Browse files

spi: stm32: FIFO threshold level - fix align packet size 



if cur_bpw <= 8 and xfer_len < 4 then the value of fthlv will be 1 and
SPI registers content may have been lost.

* If SPI data register is accessed as a 16-bit register and DSIZE <= 8bit,
  better to select FTHLV = 2, 4, 6 etc

* If SPI data register is accessed as a 32-bit register and DSIZE > 8bit,
  better to select FTHLV = 2, 4, 6 etc, while if DSIZE <= 8bit,
  better to select FTHLV = 4, 8, 12 etc

Signed-off-by: default avatarRoman Guskov <rguskov@dh-electronics.com>
Fixes: dcbe0d84 ("spi: add driver for STM32 SPI controller")
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Link: https://lore.kernel.org/r/20201221123532.27272-1-rguskov@dh-electronics.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 17fa81aa

drivers/spi/spi-stm32.c

+2 −2
Original line number Diff line number Diff line
@@ -493,9 +493,9 @@ static u32 stm32h7_spi_prepare_fthlv(struct stm32_spi *spi, u32 xfer_len) 


	/* align packet size with data registers access */

	if (spi->cur_bpw > 8)

		fthlv -= (fthlv % 2); /* multiple of 2 */

		fthlv += (fthlv % 2) ? 1 : 0;

	else

		fthlv -= (fthlv % 4); /* multiple of 4 */

		fthlv += (fthlv % 4) ? (4 - (fthlv % 4)) : 0;



	if (!fthlv)

		fthlv = 1;