Unverified Commit 17fa81aa authored by Douglas Anderson's avatar Douglas Anderson Committed by Mark Brown
Browse files

spi: spi-geni-qcom: Print an error when we timeout setting the CS 



If we're using geni to manage the chip select line (don't do it--use a
GPIO!) and we happen to get a timeout waiting for the chip select
command to be completed, no errors are printed even though things
might not be in the best shape.  Let's add a print.

Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarStephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20201217142842.v3.4.I666b37646de9652cef438ac7c2c6c2053367fc6b@changeid


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3d7d916f

drivers/spi/spi-geni-qcom.c

+3 −1
Original line number Diff line number Diff line
@@ -223,8 +223,10 @@ static void spi_geni_set_cs(struct spi_device *slv, bool set_flag) 
	spin_unlock_irq(&mas->lock);



	time_left = wait_for_completion_timeout(&mas->cs_done, HZ);

	if (!time_left)

	if (!time_left) {

		dev_warn(mas->dev, "Timeout setting chip select\n");

		handle_fifo_timeout(spi, NULL);

	}



exit:

	pm_runtime_put(mas->dev);