Commit a42989e7 authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini
Browse files

KVM: x86/mmu: Directly "destroy" PTE list when recycling rmaps 



Use pte_list_destroy() directly when recycling rmaps instead of bouncing
through kvm_unmap_rmapp() and kvm_zap_rmapp().  Calling kvm_unmap_rmapp()
is unnecessary and odd as it requires passing dummy parameters; passing
NULL for @slot when __rmap_add() already has a valid slot is especially
weird and confusing.

No functional change intended.

Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Message-Id: <20220715224226.3749507-3-seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 35d539c3

arch/x86/kvm/mmu/mmu.c

+1 −1
Original line number Diff line number Diff line
@@ -1596,7 +1596,7 @@ static void __rmap_add(struct kvm *kvm, 
	rmap_count = pte_list_add(cache, spte, rmap_head);



	if (rmap_count > RMAP_RECYCLE_THRESHOLD) {

		kvm_unmap_rmapp(kvm, rmap_head, NULL, gfn, sp->role.level, __pte(0));

		pte_list_destroy(kvm, rmap_head);

		kvm_flush_remote_tlbs_with_address(

				kvm, sp->gfn, KVM_PAGES_PER_HPAGE(sp->role.level));

	}