Commit 35d539c3 authored by Sean Christopherson's avatar Sean Christopherson Committed by Paolo Bonzini
Browse files

KVM: x86/mmu: Return a u64 (the old SPTE) from mmu_spte_clear_track_bits() 



Return a u64, not an int, from mmu_spte_clear_track_bits().  The return
value is the old SPTE value, which is very much a 64-bit value.  The sole
caller that consumes the return value, drop_spte(), already uses a u64.
The only reason that truncating the SPTE value is not problematic is
because drop_spte() only queries the shadow-present bit, which is in the
lower 32 bits.

Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
Message-Id: <20220715224226.3749507-2-seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent da0b93d6

arch/x86/kvm/mmu/mmu.c

+1 −1
Original line number Diff line number Diff line
@@ -529,7 +529,7 @@ static bool mmu_spte_update(u64 *sptep, u64 new_spte) 
 * state bits, it is used to clear the last level sptep.

 * Returns the old PTE.

 */

static int mmu_spte_clear_track_bits(struct kvm *kvm, u64 *sptep)

static u64 mmu_spte_clear_track_bits(struct kvm *kvm, u64 *sptep)

{

	kvm_pfn_t pfn;

	u64 old_spte = *sptep;