Commit a13bb2c0 authored Feb 07, 2023 by Josef Bacik Committed by David Sterba Apr 17, 2023

btrfs: add missing iputs on orphan cleanup failure



We missed a couple of iput()s in the orphan cleanup failure paths, add
them so we don't get refcount errors. The iput needs to be done in the
check and not under a common label due to the way the code is
structured.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 9cf14029

fs/btrfs/inode.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -3691,6 +3691,7 @@ int btrfs_orphan_cleanup(struct btrfs_root *root)
		trans = btrfs_start_transaction(root, 1);
		if (IS_ERR(trans)) {
		ret = PTR_ERR(trans);
		iput(inode);
		goto out;
		}
		btrfs_debug(fs_info, "auto deleting %Lu",
		@@ -3698,8 +3699,10 @@ int btrfs_orphan_cleanup(struct btrfs_root *root)
		ret = btrfs_del_orphan_item(trans, root,
		found_key.objectid);
		btrfs_end_transaction(trans);
		if (ret)
		if (ret) {
		iput(inode);
		goto out;
		}
		continue;
		}