staging: comedi: pcl818: Fix endian problem for AI command data

stable inclusion
from stable-5.10.24
commit a854bd0514650c7b20a3d4adca951a0a9fef0c0b
bugzilla: 51348

--------------------------------

commit 148e34fd upstream.

The analog input subdevice supports Comedi asynchronous commands that
use Comedi's 16-bit sample format.  However, the call to
`comedi_buf_write_samples()` is passing the address of a 32-bit integer
parameter.  On bigendian machines, this will copy 2 bytes from the wrong
end of the 32-bit value.  Fix it by changing the type of the parameter
holding the sample value to `unsigned short`.

[Note: the bug was introduced in commit edf4537b ("staging: comedi:
pcl818: use comedi_buf_write_samples()") but the patch applies better to
commit d615416d ("staging: comedi: pcl818: introduce
pcl818_ai_write_sample()").]

Fixes: d615416d ("staging: comedi: pcl818: introduce pcl818_ai_write_sample()")
Cc: <stable@vger.kernel.org> # 4.0+
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20210223143055.257402-10-abbotti@mev.co.uk


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Chen Jun <chenjun102@huawei.com>
Acked-by:   Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>