Commit 9f60675a authored by Serge Semin's avatar Serge Semin Committed by Krzysztof Kozlowski
Browse files

dt-bindings: memory: snps,dw-umctl2-ddrc: Use more descriptive device name 



The DT-schema name and the corresponding generic compatible string look
inappropriate in the current DW uMCTL2 DDRC DT-bindings:
1. DT-schema name contains undefined vendor-prefix. It's supposed to be
"snps", not "synopsys".
2. DT-schema name has "ecc" suffix. That is a device property, and has
nothing to do with the controller actual name.
3. The controller name is different. It's DW uMCTL2 DDRC. Just DDRC
doesn't identify the IP-core in subject.
4. There is no much point in using the IP-core version in the device name
since it can be retrieved from the corresponding device CSR. Moreover the
DW uMCTL2 DDRC driver doesn't differentiate the IP-core version at the
current state.

In order to fix all the inconsistencies described above we suggest to
rename the DT-schema to "snps,dw-umctl2-ddrc.yaml", deprecate the
compatible string "snps,ddrc-3.80a" and define a new generic device
name as "snps,dw-umctl2-ddrc".

Signed-off-by: default avatarSerge Semin <Sergey.Semin@baikalelectronics.ru>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220910194237.10142-16-Sergey.Semin@baikalelectronics.ru
parent 84508131

Documentation/devicetree/bindings/memory-controllers/synopsys,ddrc-ecc.yaml→Documentation/devicetree/bindings/memory-controllers/snps,dw-umctl2-ddrc.yaml

+5 −2
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

%YAML 1.2

---

$id: http://devicetree.org/schemas/memory-controllers/synopsys,ddrc-ecc.yaml#

$id: http://devicetree.org/schemas/memory-controllers/snps,dw-umctl2-ddrc.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: Synopsys DesignWare Universal Multi-Protocol Memory Controller
@@ -24,8 +24,11 @@ description: | 
properties:

  compatible:

    oneOf:

      - description: Synopsys DW uMCTL2 DDR controller v3.80a

      - deprecated: true

        description: Synopsys DW uMCTL2 DDR controller v3.80a

        const: snps,ddrc-3.80a

      - description: Synopsys DW uMCTL2 DDR controller

        const: snps,dw-umctl2-ddrc

      - description: Xilinx ZynqMP DDR controller v2.40a

        const: xlnx,zynqmp-ddrc-2.40a

MAINTAINERS

+1 −0
Original line number Diff line number Diff line
@@ -3087,6 +3087,7 @@ W: http://wiki.xilinx.com 
T:	git https://github.com/Xilinx/linux-xlnx.git

F:	Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml

F:	Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml

F:	Documentation/devicetree/bindings/memory-controllers/snps,dw-umctl2-ddrc.yaml

F:	Documentation/devicetree/bindings/memory-controllers/xlnx,zynq-ddrc-a05.yaml

F:	Documentation/devicetree/bindings/spi/xlnx,zynq-qspi.yaml

F:	arch/arm/mach-zynq/