Commit 9e58df97 authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'irq-core-2023-02-20' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip 

Pull irq updates from Thomas Gleixner:
 "Updates for the interrupt subsystem:

  Core:

   - Move the interrupt affinity spreading mechanism into lib/group_cpus
     so it can be used for similar spreading requirements, e.g. in the
     block multi-queue code

     This also contains a first usecase in the block multi-queue code
     which Jens asked to take along with the librarization

   - Improve irqdomain locking to close a number race conditions which
     can be observed with massive parallel device driver probing

   - Enforce and document the semantics of disable_irq() which cannot be
     invoked safely from non-sleepable context

   - Move the IPI multiplexing code from the Apple AIC driver into the
     core, so it can be reused by RISCV

  Drivers:

   - Plug OF node refcounting leaks in various drivers

   - Correctly mark level triggered interrupts in the Broadcom L2
     drivers

   - The usual small fixes and improvements

   - No new drivers for the record!"

* tag 'irq-core-2023-02-20' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: (42 commits)
  irqchip/irq-bcm7120-l2: Set IRQ_LEVEL for level triggered interrupts
  irqchip/irq-brcmstb-l2: Set IRQ_LEVEL for level triggered interrupts
  irqdomain: Switch to per-domain locking
  irqchip/mvebu-odmi: Use irq_domain_create_hierarchy()
  irqchip/loongson-pch-msi: Use irq_domain_create_hierarchy()
  irqchip/gic-v3-mbi: Use irq_domain_create_hierarchy()
  irqchip/gic-v3-its: Use irq_domain_create_hierarchy()
  irqchip/gic-v2m: Use irq_domain_create_hierarchy()
  irqchip/alpine-msi: Use irq_domain_add_hierarchy()
  x86/uv: Use irq_domain_create_hierarchy()
  x86/ioapic: Use irq_domain_create_hierarchy()
  irqdomain: Clean up irq_domain_push/pop_irq()
  irqdomain: Drop leftover brackets
  irqdomain: Drop dead domain-name assignment
  irqdomain: Drop revmap mutex
  irqdomain: Fix domain registration race
  irqdomain: Fix mapping-creation race
  irqdomain: Refactor __irq_domain_alloc_irqs()
  irqdomain: Look for existing mapping only once
  irqdomain: Drop bogus fwspec-mapping error handling
  ...
parents 560b8030 6f3ee0e2

Documentation/kernel-hacking/locking.rst

+2 −2
Original line number Diff line number Diff line
@@ -1277,11 +1277,11 @@ Manfred Spraul points out that you can still do this, even if the data 
is very occasionally accessed in user context or softirqs/tasklets. The

irq handler doesn't use a lock, and all other accesses are done as so::



        spin_lock(&lock);

        mutex_lock(&lock);

        disable_irq(irq);

        ...

        enable_irq(irq);

        spin_unlock(&lock);

        mutex_unlock(&lock);



The disable_irq() prevents the irq handler from running

(and waits for it to finish if it's currently running on other CPUs).

Documentation/translations/it_IT/kernel-hacking/locking.rst

+2 −2
Original line number Diff line number Diff line
@@ -1307,11 +1307,11 @@ se i dati vengono occasionalmente utilizzati da un contesto utente o 
da un'interruzione software. Il gestore d'interruzione non utilizza alcun

*lock*, e tutti gli altri accessi verranno fatti così::



        spin_lock(&lock);

        mutex_lock(&lock);

        disable_irq(irq);

        ...

        enable_irq(irq);

        spin_unlock(&lock);

        mutex_unlock(&lock);



La funzione disable_irq() impedisce al gestore d'interruzioni

d'essere eseguito (e aspetta che finisca nel caso fosse in esecuzione su

MAINTAINERS

+2 −0
Original line number Diff line number Diff line
@@ -10777,6 +10777,8 @@ L: linux-kernel@vger.kernel.org 
S:	Maintained

T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core

F:	kernel/irq/

F:	include/linux/group_cpus.h

F:	lib/group_cpus.c









IRQCHIP DRIVERS









M:	Thomas Gleixner <tglx@linutronix.de>
































arch/x86/kernel/apic/io_apic.c



+2
−5






























Original line number
Diff line number
Diff line







@@ -2364,9 +2364,8 @@ static int mp_irqdomain_create(int ioapic)







		return -ENODEV;









	}



















	ip->irqdomain = irq_domain_create_linear(fn, hwirqs, cfg->ops,









	ip->irqdomain = irq_domain_create_hierarchy(parent, 0, hwirqs, fn, cfg->ops,









						    (void *)(long)ioapic);



















	if (!ip->irqdomain) {









		/* Release fw handle if it was allocated above */









		if (!cfg->dev)








@@ -2374,8 +2373,6 @@ static int mp_irqdomain_create(int ioapic)







		return -ENOMEM;









	}



















	ip->irqdomain->parent = parent;



















	if (cfg->type == IOAPIC_DOMAIN_LEGACY ||









	    cfg->type == IOAPIC_DOMAIN_STRICT)









		ioapic_dynirq_base = max(ioapic_dynirq_base,
































arch/x86/platform/uv/uv_irq.c



+3
−4






























Original line number
Diff line number
Diff line







@@ -166,10 +166,9 @@ static struct irq_domain *uv_get_irq_domain(void)







	if (!fn)









		goto out;



















	uv_domain = irq_domain_create_tree(fn, &uv_domain_ops, NULL);









	if (uv_domain)









		uv_domain->parent = x86_vector_domain;









	else









	uv_domain = irq_domain_create_hierarchy(x86_vector_domain, 0, 0, fn,









						&uv_domain_ops, NULL);









	if (!uv_domain)









		irq_domain_free_fwnode(fn);









out:









	mutex_unlock(&uv_lock);