Commit 9ca9a252 authored Oct 19, 2020 by Ahmed S. Darwish Committed by Greg Kroah-Hartman Oct 28, 2020

usbip: Remove in_interrupt() check



The usage of in_interrupt() in drivers is phased out and Linus clearly
requested that code which changes behaviour depending on context should
either be separated or the context be conveyed in an argument passed by the
caller, which usually knows the context.

usbip_recv() uses in_interrupt() to conditionally print context information
for debugging messages. The value is zero as the function is only called
from various *_rx_loop() kthread functions. Remove it.

Signed-off-by: Ahmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Cc: Valentina Manea <valentina.manea.m@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org

Link: https://lore.kernel.org/r/20201019101110.332963099@linutronix.de


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent b02dfc13

drivers/usb/usbip/usbip_common.c

+0 −5

Original line number	Original line	Diff line number	Diff line
	@@ -324,11 +324,6 @@ int usbip_recv(struct socket sock, void buf, int size)
	} while (msg_data_left(&msg));		} while (msg_data_left(&msg));

	if (usbip_dbg_flag_xmit) {		if (usbip_dbg_flag_xmit) {
	if (!in_interrupt())
	pr_debug("%-10s:", current->comm);
	else
	pr_debug("interrupt :");

	pr_debug("receiving....\n");		pr_debug("receiving....\n");
	usbip_dump_buffer(buf, size);		usbip_dump_buffer(buf, size);
	pr_debug("received, osize %d ret %d size %zd total %d\n",		pr_debug("received, osize %d ret %d size %zd total %d\n",