Commit b02dfc13 authored by Ahmed S. Darwish's avatar Ahmed S. Darwish Committed by Greg Kroah-Hartman
Browse files

usb: gadget: pxa27x_udc: Replace in_interrupt() usage in comments 



The usage of in_interrupt() in drivers is phased out for various reasons.

Documenting calling contexts of functions with 'in_interrupt()' or
'!in_interrupt()' is imprecise: For a function which might sleep the
condition is preemptible task context, which is not what '!in_interrupt()'
describes.

Replace the context docummentation with plain text and make them match
reality.

Signed-off-by: default avatarAhmed S. Darwish <a.darwish@linutronix.de>
Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-usb@vger.kernel.org

Link: https://lore.kernel.org/r/20201019101110.636378243@linutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 41631d36

drivers/usb/gadget/udc/pxa27x_udc.c

+10 −9
Original line number Diff line number Diff line
@@ -304,7 +304,7 @@ static struct pxa_ep *find_pxa_ep(struct pxa_udc *udc, 
 * update_pxa_ep_matches - update pxa_ep cached values in all udc_usb_ep

 * @udc: pxa udc

 *

 * Context: in_interrupt()

 * Context: interrupt handler

 *

 * Updates all pxa_ep fields in udc_usb_ep structures, if this field was

 * previously set up (and is not NULL). The update is necessary is a
@@ -859,7 +859,7 @@ static int write_packet(struct pxa_ep *ep, struct pxa27x_request *req, 
 * @ep: pxa physical endpoint

 * @req: usb request

 *

 * Context: callable when in_interrupt()

 * Context: interrupt handler

 *

 * Unload as many packets as possible from the fifo we use for usb OUT

 * transfers and put them into the request. Caller should have made sure
@@ -997,7 +997,7 @@ static int read_ep0_fifo(struct pxa_ep *ep, struct pxa27x_request *req) 
 * @ep: control endpoint

 * @req: request

 *

 * Context: callable when in_interrupt()

 * Context: interrupt handler

 *

 * Sends a request (or a part of the request) to the control endpoint (ep0 in).

 * If the request doesn't fit, the remaining part will be sent from irq.
@@ -1036,8 +1036,8 @@ static int write_ep0_fifo(struct pxa_ep *ep, struct pxa27x_request *req) 
 * @_req: usb request

 * @gfp_flags: flags

 *

 * Context: normally called when !in_interrupt, but callable when in_interrupt()

 * in the special case of ep0 setup :

 * Context: thread context or from the interrupt handler in the

 * special case of ep0 setup :

 *   (irq->handle_ep0_ctrl_req->gadget_setup->pxa_ep_queue)

 *

 * Returns 0 if succedeed, error otherwise
@@ -1512,7 +1512,8 @@ static int should_disable_udc(struct pxa_udc *udc) 
 * pxa_udc_pullup - Offer manual D+ pullup control

 * @_gadget: usb gadget using the control

 * @is_active: 0 if disconnect, else connect D+ pullup resistor

 * Context: !in_interrupt()

 *

 * Context: task context, might sleep

 *

 * Returns 0 if OK, -EOPNOTSUPP if udc driver doesn't handle D+ pullup

 */
@@ -1560,7 +1561,7 @@ static int pxa_udc_vbus_session(struct usb_gadget *_gadget, int is_active) 
 * @_gadget: usb gadget

 * @mA: current drawn

 *

 * Context: !in_interrupt()

 * Context: task context, might sleep

 *

 * Called after a configuration was chosen by a USB host, to inform how much

 * current can be drawn by the device from VBus line.
@@ -1886,7 +1887,7 @@ static void handle_ep0_ctrl_req(struct pxa_udc *udc, 
 * @fifo_irq: 1 if triggered by fifo service type irq

 * @opc_irq: 1 if triggered by output packet complete type irq

 *

 * Context : when in_interrupt() or with ep->lock held

 * Context : interrupt handler

 *

 * Tries to transfer all pending request data into the endpoint and/or

 * transfer all pending data in the endpoint into usb requests.
@@ -2011,7 +2012,7 @@ static void handle_ep0(struct pxa_udc *udc, int fifo_irq, int opc_irq) 
 * Tries to transfer all pending request data into the endpoint and/or

 * transfer all pending data in the endpoint into usb requests.

 *

 * Is always called when in_interrupt() and with ep->lock released.

 * Is always called from the interrupt handler. ep->lock must not be held.

 */

static void handle_ep(struct pxa_ep *ep)

{