Commit 99d0f3a1 authored Mar 21, 2023 by Russell King (Oracle) Committed by Jakub Kicinski Mar 22, 2023

net: dpaa2-mac: use Autoneg bit rather than an_enabled



The Autoneg bit in the advertising bitmap and state->an_enabled are
always identical. Thus, we will be removing state->an_enabled.

Use the Autoneg bit in the advertising bitmap to indicate whether
autonegotiation should be used, rather than using the an_enabled
member which will be going away. This means we use the same condition
as phylink_mii_c22_pcs_config().

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 1cc6571f

drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -159,7 +159,8 @@ static void dpaa2_mac_config(struct phylink_config *config, unsigned int mode,
		struct dpmac_link_state *dpmac_state = &mac->state;
		int err;

		if (state->an_enabled)
		if (linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
		state->advertising))
		dpmac_state->options \|= DPMAC_LINK_OPT_AUTONEG;
		else
		dpmac_state->options &= ~DPMAC_LINK_OPT_AUTONEG;