Commit 1cc6571f authored by Nick Child's avatar Nick Child Committed by Jakub Kicinski
Browse files

netdev: Enforce index cap in netdev_get_tx_queue 



When requesting a TX queue at a given index, warn on out-of-bounds
referencing if the index is greater than the allocated number of
queues.

Specifically, since this function is used heavily in the networking
stack use DEBUG_NET_WARN_ON_ONCE to avoid executing a new branch on
every packet.

Signed-off-by: default avatarNick Child <nnac123@linux.ibm.com>
Link: https://lore.kernel.org/r/20230321150725.127229-2-nnac123@linux.ibm.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5dd0dfd5

include/linux/netdevice.h

+1 −0
Original line number Diff line number Diff line
@@ -2484,6 +2484,7 @@ static inline 
struct netdev_queue *netdev_get_tx_queue(const struct net_device *dev,

					 unsigned int index)

{

	DEBUG_NET_WARN_ON_ONCE(index >= dev->num_tx_queues);

	return &dev->_tx[index];

}