Commit 968b66ff authored by Frank Crawford's avatar Frank Crawford Committed by Guenter Roeck
Browse files

hwmon (it87): Fix voltage scaling for chips with 10.9mV ADCs 



Fix voltage scaling for chips that have 10.9mV ADCs, where scaling was
not performed.

Fixes: ead80803 ("hwmon: (it87) Add support for IT8732F")
Signed-off-by: default avatarFrank Crawford <frank@crawford.emu.id.au>
Link: https://lore.kernel.org/r/20230318080543.1226700-2-frank@crawford.emu.id.au


[groeck: Update subject and description to focus on bug fix]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 813cc94c

drivers/hwmon/it87.c

+3 −1
Original line number Diff line number Diff line
@@ -515,6 +515,8 @@ static const struct it87_devices it87_devices[] = { 
#define has_six_temp(data)	((data)->features & FEAT_SIX_TEMP)

#define has_vin3_5v(data)	((data)->features & FEAT_VIN3_5V)

#define has_conf_noexit(data)	((data)->features & FEAT_CONF_NOEXIT)

#define has_scaling(data)	((data)->features & (FEAT_12MV_ADC | \

						     FEAT_10_9MV_ADC))



struct it87_sio_data {

	int sioaddr;
@@ -3134,7 +3136,7 @@ static int it87_probe(struct platform_device *pdev) 
			 "Detected broken BIOS defaults, disabling PWM interface\n");



	/* Starting with IT8721F, we handle scaling of internal voltages */

	if (has_12mv_adc(data)) {

	if (has_scaling(data)) {

		if (sio_data->internal & BIT(0))

			data->in_scaled |= BIT(3);	/* in3 is AVCC */

		if (sio_data->internal & BIT(1))