Commit 813cc94c authored Mar 18, 2023 by Tianyi Jing Committed by Guenter Roeck Mar 21, 2023

hwmon: (xgene) Fix ioremap and memremap leak



Smatch reports:

drivers/hwmon/xgene-hwmon.c:757 xgene_hwmon_probe() warn:
'ctx->pcc_comm_addr' from ioremap() not released on line: 757.

This is because in drivers/hwmon/xgene-hwmon.c:701 xgene_hwmon_probe(),
ioremap and memremap is not released, which may cause a leak.

To fix this, ioremap and memremap is modified to devm_ioremap and
devm_memremap.

Signed-off-by: Tianyi Jing <jingfelix@hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@hust.edu.cn>
Link: https://lore.kernel.org/r/20230318143851.2191625-1-jingfelix@hust.edu.cn


[groeck: Fixed formatting and subject]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 2315332e

drivers/hwmon/xgene-hwmon.c

+7 −7

Original line number	Diff line number	Diff line
		@@ -698,11 +698,11 @@ static int xgene_hwmon_probe(struct platform_device *pdev)
		ctx->comm_base_addr = pcc_chan->shmem_base_addr;
		if (ctx->comm_base_addr) {
		if (version == XGENE_HWMON_V2)
		ctx->pcc_comm_addr = (void __force *)ioremap(
		ctx->pcc_comm_addr = (void __force *)devm_ioremap(&pdev->dev,
		ctx->comm_base_addr,
		pcc_chan->shmem_size);
		else
		ctx->pcc_comm_addr = memremap(
		ctx->pcc_comm_addr = devm_memremap(&pdev->dev,
		ctx->comm_base_addr,
		pcc_chan->shmem_size,
		MEMREMAP_WB);