Commit 9680810f authored by muansari's avatar muansari Committed by Alex Deucher
Browse files

drm/amd/display: Modify DML to adjust Vstartup Position 



[WHY]
The Vstartup position should be as late as possible to
maximize power saving with the current. Calculation of
Vstartup in DML does not take into account as SDP signal.

[HOW]
Made necessary changes to calculate the correct Vstartup
position in DML to account for AS SDP
* Overriding the VBlankNom value in certain cases
  otherwise it will use the default value
* Bypassing the condition for adjust_sync_Vstartup
* Overriding vblank_nom_input with VBlankNom that is
  set in the SW Layer

Reviewed-by: default avatarAnthony Koo <Anthony.Koo@amd.com>
Acked-by: default avatarWayne Lin <wayne.lin@amd.com>
Signed-off-by: default avatarmuansari <muansari@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent d1a4ae58

drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c

+2 −0
Original line number Diff line number Diff line
@@ -323,6 +323,8 @@ int dcn314_populate_dml_pipes_from_context_fpu(struct dc *dc, struct dc_state *c 
		pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_luma = 0;

		pipes[pipe_cnt].pipe.src.dcc_fraction_of_zs_req_chroma = 0;

		pipes[pipe_cnt].pipe.dest.vfront_porch = timing->v_front_porch;

		pipes[pipe_cnt].pipe.dest.vblank_nom =

				dcn3_14_ip.VBlankNomDefaultUS / (timing->h_total / (timing->pix_clk_100hz / 10000.0));

		pipes[pipe_cnt].pipe.src.dcc_rate = 3;

		pipes[pipe_cnt].dout.dsc_input_bpc = 0;

drivers/gpu/drm/amd/display/dc/dml/dcn314/display_mode_vba_314.c

+1 −1
Original line number Diff line number Diff line
@@ -7407,7 +7407,7 @@ static unsigned int CalculateMaxVStartup( 
	double line_time_us = HTotal / PixelClock;

	unsigned int vblank_actual = VTotal - VActive;

	unsigned int vblank_nom_default_in_line = dml_floor(VBlankNomDefaultUS / line_time_us, 1.0);

	unsigned int vblank_nom_input = dml_min(VBlankNom, vblank_nom_default_in_line);

	unsigned int vblank_nom_input = VBlankNom; //dml_min(VBlankNom, vblank_nom_default_in_line);

	unsigned int vblank_avail = vblank_nom_input == 0 ? vblank_nom_default_in_line : vblank_nom_input;



	vblank_size = (unsigned int) dml_min(vblank_actual, vblank_avail);

drivers/gpu/drm/amd/display/dc/dml/display_mode_structs.h

+1 −0
Original line number Diff line number Diff line
@@ -510,6 +510,7 @@ struct _vcs_dpi_display_pipe_dest_params_st { 
	unsigned int htotal;

	unsigned int vtotal;

	unsigned int vfront_porch;

	unsigned int vblank_nom;

	unsigned int vactive;

	unsigned int hactive;

	unsigned int vstartup_start;

drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c

+1 −0
Original line number Diff line number Diff line
@@ -597,6 +597,7 @@ static void fetch_pipe_params(struct display_mode_lib *mode_lib) 
		mode_lib->vba.HTotal[mode_lib->vba.NumberOfActivePlanes] = dst->htotal;

		mode_lib->vba.VTotal[mode_lib->vba.NumberOfActivePlanes] = dst->vtotal;

		mode_lib->vba.VFrontPorch[mode_lib->vba.NumberOfActivePlanes] = dst->vfront_porch;

		mode_lib->vba.VBlankNom[mode_lib->vba.NumberOfActivePlanes] = dst->vblank_nom;

		mode_lib->vba.DCCFractionOfZeroSizeRequestsLuma[mode_lib->vba.NumberOfActivePlanes] = src->dcc_fraction_of_zs_req_luma;

		mode_lib->vba.DCCFractionOfZeroSizeRequestsChroma[mode_lib->vba.NumberOfActivePlanes] = src->dcc_fraction_of_zs_req_chroma;

		mode_lib->vba.DCCEnable[mode_lib->vba.NumberOfActivePlanes] =