Commit d1a4ae58 authored Sep 06, 2022 by Nicholas Kazlauskas Committed by Alex Deucher Sep 19, 2022

drm/amd/display: Disable OTG WA for the plane_state NULL case on DCN314



[Why]
This shouldn't trigger during tiled display hotplug/unplug but it does
because one of the tiles can end up with a NULL plane state.

This also doesn't guard against the hang that it was originally trying
to resolve, and can instead cause DIO corruption due to OTG sync
being lost.

[How]
This was reverted at one point out of DCN31 so revert it here too.

Reviewed-by: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Acked-by: Wayne Lin <wayne.lin@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent e294bf36

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_clk_mgr.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -136,8 +136,7 @@ static void dcn314_disable_otg_wa(struct clk_mgr *clk_mgr_base, struct dc_state

		if (pipe->top_pipe \|\| pipe->prev_odm_pipe)
		continue;
		if (pipe->stream && (pipe->stream->dpms_off \|\| pipe->plane_state == NULL \|\|
		dc_is_virtual_signal(pipe->stream->signal))) {
		if (pipe->stream && (pipe->stream->dpms_off \|\| dc_is_virtual_signal(pipe->stream->signal))) {
		if (disable) {
		pipe->stream_res.tg->funcs->immediate_disable_crtc(pipe->stream_res.tg);
		reset_sync_context_for_pipe(dc, context, i);