Unverified Commit 92c6ec60 authored by Bard Liao's avatar Bard Liao Committed by Mark Brown
Browse files

ASoC: SOF: intel: hda-loader: use snd_sof_dsp_core_power_down/up APIs 



To manage enabled_cores_mask flag, we should always use snd_sof_dsp_
core_power_down/up APIs to power up/down dsp cores. The APIs do
a little bit more than the original functions, but it is harmless.

Suggested-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20210128093850.1041387-6-kai.vehmanen@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 30876e2a

sound/soc/sof/intel/hda-loader.c

+3 −3
Original line number Diff line number Diff line
@@ -93,7 +93,7 @@ static int cl_dsp_init(struct snd_sof_dev *sdev, int stream_tag) 
	int i;



	/* step 1: power up corex */

	ret = hda_dsp_core_power_up(sdev, chip->host_managed_cores_mask);

	ret = snd_sof_dsp_core_power_up(sdev, chip->host_managed_cores_mask);

	if (ret < 0) {

		if (hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS)

			dev_err(sdev->dev, "error: dsp core 0/1 power up failed\n");
@@ -148,7 +148,7 @@ static int cl_dsp_init(struct snd_sof_dev *sdev, int stream_tag) 
				       chip->ipc_ack_mask);



	/* step 5: power down cores that are no longer needed */

	ret = hda_dsp_core_power_down(sdev, chip->host_managed_cores_mask &

	ret = snd_sof_dsp_core_power_down(sdev, chip->host_managed_cores_mask &

					  ~(chip->init_core_mask));

	if (ret < 0) {

		if (hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS)