Commit 91c0c3b3 authored by Hangbin Liu's avatar Hangbin Liu Committed by Yongqiang Liu
Browse files

net/packet: fix packet_sock xmit return value checking

stable inclusion
from stable-4.19.240
commit 9be70070b00c9f3a55d89a98f08264725cf45981
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I5A6BA


CVE: NA

--------------------------------

[ Upstream commit 29e8e659 ]

packet_sock xmit could be dev_queue_xmit, which also returns negative
errors. So only checking positive errors is not enough, or userspace
sendmsg may return success while packet is not send out.

Move the net_xmit_errno() assignment in the braces as checkpatch.pl said
do not use assignment in if condition.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Reported-by: default avatarFlavio Leitner <fbl@redhat.com>
Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarYongqiang Liu <liuyongqiang13@huawei.com>
parent 46058a31
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment