Unverified Commit 91888125 authored Mar 04, 2022 by Pierre-Louis Bossart Committed by Mark Brown Mar 07, 2022

ASoC: SOF: debug: clarify operator precedence



cppcheck warning:

for '&' and '?'. [clarifyCalculation]
 char *level = flags & SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;
                                             ^

sound/soc/sof/debug.c:398:46: style: Clarify calculation precedence
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220304205733.62233-10-pierre-louis.bossart@linux.intel.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent 4aaa06b2

sound/soc/sof/debug.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -395,7 +395,7 @@ static void snd_sof_dbg_print_fw_state(struct snd_sof_dev sdev, const char lev

		void snd_sof_dsp_dbg_dump(struct snd_sof_dev sdev, const char msg, u32 flags)
		{
		char *level = flags & SOF_DBG_DUMP_OPTIONAL ? KERN_DEBUG : KERN_ERR;
		char *level = (flags & SOF_DBG_DUMP_OPTIONAL) ? KERN_DEBUG : KERN_ERR;
		bool print_all = sof_debug_check_flag(SOF_DBG_PRINT_ALL_DUMPS);

		if (flags & SOF_DBG_DUMP_OPTIONAL && !print_all)