Unverified Commit 4aaa06b2 authored Mar 04, 2022 by Curtis Malainey Committed by Mark Brown Mar 07, 2022

ASoC: SOF: fix 32 signed bit overflow

Shifting in a signed 32bit container past the signed bit is technically
undefined behaviour. Fix by using unsigned types. Found via cppcheck.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220304205733.62233-9-pierre-louis.bossart@linux.intel.com

Signed-off-by: Mark Brown <broonie@kernel.org>

parent 8e85cab8

include/sound/sof/header.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -31,7 +31,7 @@

		/* Global Message - Generic */
		#define SOF_GLB_TYPE_SHIFT 28
		#define SOF_GLB_TYPE_MASK (0xfL << SOF_GLB_TYPE_SHIFT)
		#define SOF_GLB_TYPE_MASK (0xfUL << SOF_GLB_TYPE_SHIFT)
		#define SOF_GLB_TYPE(x) ((x) << SOF_GLB_TYPE_SHIFT)

		/* Command Message - Generic */

include/uapi/sound/sof/abi.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -27,7 +27,7 @@
		/* SOF ABI version major, minor and patch numbers */
		#define SOF_ABI_MAJOR 3
		#define SOF_ABI_MINOR 19
		#define SOF_ABI_PATCH 0
		#define SOF_ABI_PATCH 1

		/* SOF ABI version number. Format within 32bit word is MMmmmppp */
		#define SOF_ABI_MAJOR_SHIFT 24