Unverified Commit 91241ee2 authored by Cai Huoqing's avatar Cai Huoqing Committed by Maxime Ripard
Browse files

drm/sun4i: dw-hdmi: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916105633.12162-1-caihuoqing@baidu.com
parent b41e24a5

drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c

+9 −12
Original line number Diff line number Diff line
@@ -153,22 +153,19 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master, 
		return -EPROBE_DEFER;



	hdmi->rst_ctrl = devm_reset_control_get(dev, "ctrl");

	if (IS_ERR(hdmi->rst_ctrl)) {

		dev_err(dev, "Could not get ctrl reset control\n");

		return PTR_ERR(hdmi->rst_ctrl);

	}

	if (IS_ERR(hdmi->rst_ctrl))

		return dev_err_probe(dev, PTR_ERR(hdmi->rst_ctrl),

				     "Could not get ctrl reset control\n");



	hdmi->clk_tmds = devm_clk_get(dev, "tmds");

	if (IS_ERR(hdmi->clk_tmds)) {

		dev_err(dev, "Couldn't get the tmds clock\n");

		return PTR_ERR(hdmi->clk_tmds);

	}

	if (IS_ERR(hdmi->clk_tmds))

		return dev_err_probe(dev, PTR_ERR(hdmi->clk_tmds),

				     "Couldn't get the tmds clock\n");



	hdmi->regulator = devm_regulator_get(dev, "hvcc");

	if (IS_ERR(hdmi->regulator)) {

		dev_err(dev, "Couldn't get regulator\n");

		return PTR_ERR(hdmi->regulator);

	}

	if (IS_ERR(hdmi->regulator))

		return dev_err_probe(dev, PTR_ERR(hdmi->regulator),

				     "Couldn't get regulator\n");



	ret = sun8i_dw_hdmi_find_connector_pdev(dev, &connector_pdev);

	if (!ret) {