Commit 90361693 authored by Dinghao Liu's avatar Dinghao Liu Committed by Mauro Carvalho Chehab
Browse files

media: coda: Fix runtime PM imbalance on error 



pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent e40a8770

drivers/media/platform/coda/coda-common.c

+2 −3
Original line number Diff line number Diff line
@@ -2653,7 +2653,7 @@ static int coda_open(struct file *file) 


	ret = clk_prepare_enable(dev->clk_per);

	if (ret)

		goto err_clk_per;

		goto err_pm_get;



	ret = clk_prepare_enable(dev->clk_ahb);

	if (ret)
@@ -2692,9 +2692,8 @@ static int coda_open(struct file *file) 
	clk_disable_unprepare(dev->clk_ahb);

err_clk_ahb:

	clk_disable_unprepare(dev->clk_per);

err_clk_per:

	pm_runtime_put_sync(dev->dev);

err_pm_get:

	pm_runtime_put_sync(dev->dev);

	v4l2_fh_del(&ctx->fh);

	v4l2_fh_exit(&ctx->fh);

err_coda_name_init: