Commit e40a8770 authored by Dinghao Liu's avatar Dinghao Liu Committed by Mauro Carvalho Chehab
Browse files

media: fimc-capture: Fix runtime PM imbalance on error 



pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 157282a5

drivers/media/platform/exynos4-is/fimc-capture.c

+3 −1
Original line number Diff line number Diff line
@@ -478,8 +478,10 @@ static int fimc_capture_open(struct file *file) 


	set_bit(ST_CAPT_BUSY, &fimc->state);

	ret = pm_runtime_get_sync(&fimc->pdev->dev);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_sync(&fimc->pdev->dev);

		goto unlock;

	}



	ret = v4l2_fh_open(file);

	if (ret) {