Commit 8fff09ef authored Sep 26, 2022 by Zhengchao Shao Committed by David S. Miller Sep 28, 2022

net: sched: act_bpf: simplify code logic in tcf_bpf_init()



Both is_bpf and is_ebpf are boolean types, so
(!is_bpf && !is_ebpf) || (is_bpf && is_ebpf) can be reduced to
is_bpf == is_ebpf in tcf_bpf_init().

Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6a1dc68e

net/sched/act_bpf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -333,7 +333,7 @@ static int tcf_bpf_init(struct net net, struct nlattr nla,
		is_bpf = tb[TCA_ACT_BPF_OPS_LEN] && tb[TCA_ACT_BPF_OPS];
		is_ebpf = tb[TCA_ACT_BPF_FD];

		if ((!is_bpf && !is_ebpf) \|\| (is_bpf && is_ebpf)) {
		if (is_bpf == is_ebpf) {
		ret = -EINVAL;
		goto put_chain;
		}