Unverified Commit 8ff3f7bd authored by Jeffrey Hugo's avatar Jeffrey Hugo Committed by Manivannan Sadhasivam
Browse files

bus: mhi: core: fix potential operator-precedence with BHI macros 



The BHI_MSMHWID and BHI_OEMPKHASH macros take a value 'n' which is
a BHI register index. If 'n' is an expression rather than a simple
value, there can be an operator precedence issue which can result
in the incorrect calculation of the register offset. Adding
parentheses around the macro parameter can prevent such issues.

Signed-off-by: default avatarJeffrey Hugo <jhugo@codeaurora.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarHemant Kumar <hemantk@codeaurora.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 9b627c25

drivers/bus/mhi/core/internal.h

+2 −2
Original line number Diff line number Diff line
@@ -153,8 +153,8 @@ extern struct bus_type mhi_bus_type; 
#define BHI_SERIALNU (0x40)

#define BHI_SBLANTIROLLVER (0x44)

#define BHI_NUMSEG (0x48)

#define BHI_MSMHWID(n) (0x4C + (0x4 * n))

#define BHI_OEMPKHASH(n) (0x64 + (0x4 * n))

#define BHI_MSMHWID(n) (0x4C + (0x4 * (n)))

#define BHI_OEMPKHASH(n) (0x64 + (0x4 * (n)))

#define BHI_RSVD5 (0xC4)

#define BHI_STATUS_MASK (0xC0000000)

#define BHI_STATUS_SHIFT (30)