Unverified Commit 9b627c25 authored by Bhaumik Bhatt's avatar Bhaumik Bhatt Committed by Manivannan Sadhasivam
Browse files

bus: mhi: core: Remove double locking from mhi_driver_remove() 



There is double acquisition of the pm_lock from mhi_driver_remove()
function. Remove the read_lock_bh/read_unlock_bh calls for pm_lock
taken during a call to mhi_device_put() as the lock is acquired
within the function already. This will help avoid a potential
kernel panic.

Fixes: 189ff97c ("bus: mhi: core: Add support for data transfer")
Reported-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarBhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 3650b228

drivers/bus/mhi/core/init.c

+0 −2
Original line number Diff line number Diff line
@@ -1276,10 +1276,8 @@ static int mhi_driver_remove(struct device *dev) 
		mutex_unlock(&mhi_chan->mutex);

	}



	read_lock_bh(&mhi_cntrl->pm_lock);

	while (mhi_dev->dev_wake)

		mhi_device_put(mhi_dev);

	read_unlock_bh(&mhi_cntrl->pm_lock);



	return 0;

}