Commit 8fbf94fe authored by Yang Yingliang's avatar Yang Yingliang Committed by Conor Dooley
Browse files

soc: sifive: ccache: fix missing of_node_put() in sifive_ccache_init() 



The device_node pointer returned by of_find_matching_node() with
refcount incremented, when finish using it, the refcount need be
decreased.

Fixes: a967a289 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
parent 756344e7

drivers/soc/sifive/sifive_ccache.c

+11 −4
Original line number Diff line number Diff line
@@ -215,12 +215,16 @@ static int __init sifive_ccache_init(void) 
	if (!np)

		return -ENODEV;



	if (of_address_to_resource(np, 0, &res))

		return -ENODEV;

	if (of_address_to_resource(np, 0, &res)) {

		rc = -ENODEV;

		goto err_node_put;

	}



	ccache_base = ioremap(res.start, resource_size(&res));

	if (!ccache_base)

		return -ENOMEM;

	if (!ccache_base) {

		rc = -ENOMEM;

		goto err_node_put;

	}



	if (of_property_read_u32(np, "cache-level", &level)) {

		rc = -ENOENT;
@@ -243,6 +247,7 @@ static int __init sifive_ccache_init(void) 
			goto err_free_irq;

		}

	}

	of_node_put(np);



	ccache_config_read();
@@ -259,6 +264,8 @@ static int __init sifive_ccache_init(void) 
		free_irq(g_irq[i], NULL);

err_unmap:

	iounmap(ccache_base);

err_node_put:

	of_node_put(np);

	return rc;

}