Commit 8f08c363 authored Mar 28, 2023 by Ian Rogers Committed by Arnaldo Carvalho de Melo Apr 04, 2023

perf report: Additional config warnings



If the default_sort_order isn't correctly strdup-ed warn and return an
error. Debug warn if no option is matched.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: German Gomez <german.gomez@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Tom Rix <trix@redhat.com>
Cc: llvm@lists.linux.dev
Link: https://lore.kernel.org/r/20230328235543.1082207-2-irogers@google.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 333b1b11

tools/perf/builtin-report.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -143,6 +143,10 @@ static int report__config(const char var, const char value, void *cb)

		if (!strcmp(var, "report.sort_order")) {
		default_sort_order = strdup(value);
		if (!default_sort_order) {
		pr_err("Not enough memory for report.sort_order\n");
		return -1;
		}
		return 0;
		}

		@@ -151,6 +155,7 @@ static int report__config(const char var, const char value, void *cb)
		return 0;
		}

		pr_debug("%s variable unknown, ignoring...", var);
		return 0;
		}