Commit 333b1b11 authored Mar 28, 2023 by Ian Rogers Committed by Arnaldo Carvalho de Melo Apr 04, 2023

perf annotate: Delete session for debug builds



Use the debug build indicator as the guide to free the session. This
implements a behavior described in a comment, which is consequentially
removed.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: German Gomez <german.gomez@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Tom Rix <trix@redhat.com>
Cc: llvm@lists.linux.dev
Link: https://lore.kernel.org/r/20230328235543.1082207-2-irogers@google.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent f5ceb159

tools/perf/builtin-annotate.c

+6 −10

Original line number	Diff line number	Diff line
		@@ -692,16 +692,12 @@ int cmd_annotate(int argc, const char **argv)

		out_delete:
		/*
		* Speed up the exit process, for large files this can
		* take quite a while.
		*
		* XXX Enable this when using valgrind or if we ever
		* librarize this command.
		*
		* Also experiment with obstacks to see how much speed
		* up we'll get here.
		*
		* perf_session__delete(session);
		* Speed up the exit process by only deleting for debug builds. For
		* large files this can save time.
		*/
		#ifndef NDEBUG
		perf_session__delete(annotate.session);
		#endif

		return ret;
		}