Commit 8a4675eb authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev: Remove FBINFO_FLAG_DEFAULT from framebuffer_alloc()'ed structs 



The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So
do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
	* clarify commit message (Geert, Dan)
v2:
	* fix commit message (Miguel)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Jaya Kumar <jayalk@intworks.biz>
Cc: Helge Deller <deller@gmx.de>
Cc: Peter Jones <pjones@redhat.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Maik Broemme <mbroemme@libmpq.org>
Cc: Jingoo Han <jingoohan1@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Teddy Wang <teddy.wang@siliconmotion.com>
Cc: Michal Januszewski <spock@gentoo.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-15-tzimmermann@suse.de
parent 252b7b14

drivers/video/fbdev/arcfb.c

+0 −1
Original line number Diff line number Diff line
@@ -546,7 +546,6 @@ static int arcfb_probe(struct platform_device *dev) 
	par->c2io_addr = c2io_addr;

	par->cslut[0] = 0x00;

	par->cslut[1] = 0x06;

	info->flags = FBINFO_FLAG_DEFAULT;

	spin_lock_init(&par->lock);

	if (irq) {

		par->irq = irq;

drivers/video/fbdev/aty/aty128fb.c

+0 −1
Original line number Diff line number Diff line
@@ -1927,7 +1927,6 @@ static int aty128_init(struct pci_dev *pdev, const struct pci_device_id *ent) 


	/* fill in info */

	info->fbops = &aty128fb_ops;

	info->flags = FBINFO_FLAG_DEFAULT;



	par->lcd_on = default_lcd_on;

	par->crt_on = default_crt_on;

drivers/video/fbdev/broadsheetfb.c

+1 −1
Original line number Diff line number Diff line
@@ -1069,7 +1069,7 @@ static int broadsheetfb_probe(struct platform_device *dev) 


	mutex_init(&par->io_lock);



	info->flags = FBINFO_FLAG_DEFAULT | FBINFO_VIRTFB;

	info->flags = FBINFO_VIRTFB;



	info->fbdefio = &broadsheetfb_defio;

	fb_deferred_io_init(info);

drivers/video/fbdev/da8xx-fb.c

+0 −1
Original line number Diff line number Diff line
@@ -1463,7 +1463,6 @@ static int fb_probe(struct platform_device *device) 
	da8xx_fb_var.bits_per_pixel = lcd_cfg->bpp;



	/* Initialize fbinfo */

	da8xx_fb_info->flags = FBINFO_FLAG_DEFAULT;

	da8xx_fb_info->fix = da8xx_fb_fix;

	da8xx_fb_info->var = da8xx_fb_var;

	da8xx_fb_info->fbops = &da8xx_fb_ops;

drivers/video/fbdev/efifb.c

+0 −1
Original line number Diff line number Diff line
@@ -555,7 +555,6 @@ static int efifb_probe(struct platform_device *dev) 
	info->fbops = &efifb_ops;

	info->var = efifb_defined;

	info->fix = efifb_fix;

	info->flags = FBINFO_FLAG_DEFAULT;



	orientation = drm_get_panel_orientation_quirk(efifb_defined.xres,

						      efifb_defined.yres);