Commit 252b7b14 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev: Remove FBINFO_FLAG_DEFAULT from kzalloc()'ed structs 



The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by kzalloc(). So do not
set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
	* clarify commit message (Geert, Dan)
v2:
	* fix commit message (Miguel)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-14-tzimmermann@suse.de
parent cdeb052c

drivers/video/fbdev/amba-clcd.c

+0 −1
Original line number Diff line number Diff line
@@ -461,7 +461,6 @@ static int clcdfb_register(struct clcd_fb *fb) 
	}



	fb->fb.fbops		= &clcdfb_ops;

	fb->fb.flags		= FBINFO_FLAG_DEFAULT;

	fb->fb.pseudo_palette	= fb->cmap;



	strncpy(fb->fb.fix.id, clcd_name, sizeof(fb->fb.fix.id));

drivers/video/fbdev/matrox/matroxfb_crtc2.c

+2 −3
Original line number Diff line number Diff line
@@ -603,8 +603,7 @@ static int matroxfb_dh_regit(const struct matrox_fb_info *minfo, 
	void* oldcrtc2;



	m2info->fbcon.fbops = &matroxfb_dh_ops;

	m2info->fbcon.flags = FBINFO_FLAG_DEFAULT;

	m2info->fbcon.flags |= FBINFO_HWACCEL_XPAN |

	m2info->fbcon.flags = FBINFO_HWACCEL_XPAN |

			      FBINFO_HWACCEL_YPAN;

	m2info->fbcon.pseudo_palette = m2info->cmap;

	fb_alloc_cmap(&m2info->fbcon.cmap, 256, 1);