Commit 88f50a05 authored by Qiushi Wu's avatar Qiushi Wu Committed by Mauro Carvalho Chehab
Browse files

media: stm32-dcmi: Fix a reference count leak 



Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count if pm_runtime_put is not
called in error handling paths. Thus replace the jump target
"err_release_buffers" by "err_pm_putw".

Fixes: 152e0bf6 ("media: stm32-dcmi: add power saving support")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 78741ce9

drivers/media/platform/stm32/stm32-dcmi.c

+1 −3
Original line number Diff line number Diff line
@@ -733,7 +733,7 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count) 
	if (ret < 0) {

		dev_err(dcmi->dev, "%s: Failed to start streaming, cannot get sync (%d)\n",

			__func__, ret);

		goto err_release_buffers;

		goto err_pm_put;

	}



	ret = media_pipeline_start(&dcmi->vdev->entity, &dcmi->pipeline);
@@ -837,8 +837,6 @@ static int dcmi_start_streaming(struct vb2_queue *vq, unsigned int count) 


err_pm_put:

	pm_runtime_put(dcmi->dev);



err_release_buffers:

	spin_lock_irq(&dcmi->irqlock);

	/*

	 * Return all buffers to vb2 in QUEUED state.