Commit 78741ce9 authored by Qiushi Wu's avatar Qiushi Wu Committed by Mauro Carvalho Chehab
Browse files

media: s5p-mfc: Fix a reference count leak 



pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code, causing incorrect ref count if
pm_runtime_put_noidle() is not called in error handling paths.
Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails.

Fixes: c5086f13 ("[media] s5p-mfc: Use clock gating only on MFC v5 hardware")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent d0675b67

drivers/media/platform/s5p-mfc/s5p_mfc_pm.c

+3 −1
Original line number Diff line number Diff line
@@ -79,8 +79,10 @@ int s5p_mfc_power_on(void) 
	int i, ret = 0;



	ret = pm_runtime_get_sync(pm->device);

	if (ret < 0)

	if (ret < 0) {

		pm_runtime_put_noidle(pm->device);

		return ret;

	}



	/* clock control */

	for (i = 0; i < pm->num_clocks; i++) {