Commit 88bfdf56 authored by Jason Yan's avatar Jason Yan Committed by Martin K. Petersen
Browse files

scsi: qla2xxx: Make qlafx00_process_aen() return void 

No other functions use the return value of qlafx00_process_aen() and the
return value is always 0 now. Make it return void. This fixes the following
coccicheck warning:

drivers/scsi/qla2xxx/qla_mr.c:1716:5-9: Unneeded variable: "rval".
Return "0" on line 1768

Link: https://lore.kernel.org/r/20200506061757.19536-1-yanaijie@huawei.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent dbe6f492

drivers/scsi/qla2xxx/qla_gbl.h

+1 −1
Original line number Diff line number Diff line
@@ -771,7 +771,7 @@ extern int qlafx00_fw_ready(scsi_qla_host_t *); 
extern int qlafx00_configure_devices(scsi_qla_host_t *);

extern int qlafx00_reset_initialize(scsi_qla_host_t *);

extern int qlafx00_fx_disc(scsi_qla_host_t *, fc_port_t *, uint16_t);

extern int qlafx00_process_aen(struct scsi_qla_host *, struct qla_work_evt *);

extern void qlafx00_process_aen(struct scsi_qla_host *, struct qla_work_evt *);

extern int qlafx00_post_aenfx_work(struct scsi_qla_host *,  uint32_t,

				   uint32_t *, int);

extern uint32_t qlafx00_fw_state_show(struct device *,

drivers/scsi/qla2xxx/qla_mr.c

+1 −4
Original line number Diff line number Diff line
@@ -1710,10 +1710,9 @@ qlafx00_tgt_detach(struct scsi_qla_host *vha, int tgt_id) 
	return;

}



int

void

qlafx00_process_aen(struct scsi_qla_host *vha, struct qla_work_evt *evt)

{

	int rval = 0;

	uint32_t aen_code, aen_data;



	aen_code = FCH_EVT_VENDOR_UNIQUE;
@@ -1764,8 +1763,6 @@ qlafx00_process_aen(struct scsi_qla_host *vha, struct qla_work_evt *evt) 


	fc_host_post_event(vha->host, fc_get_event_number(),

	    aen_code, aen_data);



	return rval;

}



static void