Commit dbe6f492 authored Apr 30, 2020 by Jason Yan Committed by Martin K. Petersen May 07, 2020

scsi: qla2xxx: Use true, false for ha->fw_dumped

Fix the following coccicheck warning:

drivers/scsi/qla2xxx/qla_tmpl.c:1120:2-20: WARNING: Assignment of 0/1 to
bool variable

Link: https://lore.kernel.org/r/20200430121800.15323-1-yanaijie@huawei.com


Signed-off-by: Jason Yan <yanaijie@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent bda552a7

drivers/scsi/qla2xxx/qla_attr.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -84,7 +84,7 @@ qla2x00_sysfs_write_fw_dump(struct file filp, struct kobject kobj,
		qla82xx_md_prep(vha);
		}
		ha->fw_dump_reading = 0;
		ha->fw_dumped = 0;
		ha->fw_dumped = false;
		break;
		case 1:
		if (ha->fw_dumped && !ha->fw_dump_reading) {

drivers/scsi/qla2xxx/qla_dbg.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -706,12 +706,12 @@ qla2xxx_dump_post_process(scsi_qla_host_t *vha, int rval)
		ql_log(ql_log_warn, vha, 0xd000,
		"Failed to dump firmware (%x), dump status flags (0x%lx).\n",
		rval, ha->fw_dump_cap_flags);
		ha->fw_dumped = 0;
		ha->fw_dumped = false;
		} else {
		ql_log(ql_log_info, vha, 0xd001,
		"Firmware dump saved to temp buffer (%ld/%p), dump status flags (0x%lx).\n",
		vha->host_no, ha->fw_dump, ha->fw_dump_cap_flags);
		ha->fw_dumped = 1;
		ha->fw_dumped = true;
		qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);
		}
		}

drivers/scsi/qla2xxx/qla_nx.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -4177,7 +4177,7 @@ qla82xx_md_collect(scsi_qla_host_t *vha)
		goto md_failed;
		}

		ha->fw_dumped = 0;
		ha->fw_dumped = false;

		if (!ha->md_tmplt_hdr \|\| !ha->md_dump) {
		ql_log(ql_log_warn, vha, 0xb038,
		@@ -4357,7 +4357,7 @@ qla82xx_md_collect(scsi_qla_host_t *vha)
		ql_log(ql_log_info, vha, 0xb044,
		"Firmware dump saved to temp buffer (%ld/%p %ld/%p).\n",
		vha->host_no, ha->md_tmplt_hdr, vha->host_no, ha->md_dump);
		ha->fw_dumped = 1;
		ha->fw_dumped = true;
		qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);

		md_failed:

drivers/scsi/qla2xxx/qla_nx2.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1441,7 +1441,7 @@ qla8044_device_bootstrap(struct scsi_qla_host *vha)
		if (idc_ctrl & GRACEFUL_RESET_BIT1) {
		qla8044_wr_reg(ha, QLA8044_IDC_DRV_CTRL,
		(idc_ctrl & ~GRACEFUL_RESET_BIT1));
		ha->fw_dumped = 0;
		ha->fw_dumped = false;
		}

		dev_ready:
		@@ -3249,7 +3249,7 @@ qla8044_collect_md_data(struct scsi_qla_host *vha)
		goto md_failed;
		}

		ha->fw_dumped = 0;
		ha->fw_dumped = false;

		if (!ha->md_tmplt_hdr \|\| !ha->md_dump) {
		ql_log(ql_log_warn, vha, 0xb10e,
		@@ -3470,7 +3470,7 @@ qla8044_collect_md_data(struct scsi_qla_host *vha)
		ql_log(ql_log_info, vha, 0xb110,
		"Firmware dump saved to temp buffer (%ld/%p %ld/%p).\n",
		vha->host_no, ha->md_tmplt_hdr, vha->host_no, ha->md_dump);
		ha->fw_dumped = 1;
		ha->fw_dumped = true;
		qla2x00_post_uevent_work(vha, QLA_UEVENT_CODE_FW_DUMP);


		@@ -3487,7 +3487,7 @@ qla8044_get_minidump(struct scsi_qla_host *vha)
		struct qla_hw_data *ha = vha->hw;

		if (!qla8044_collect_md_data(vha)) {
		ha->fw_dumped = 1;
		ha->fw_dumped = true;
		ha->prev_minidump_failed = 0;
		} else {
		ql_log(ql_log_fatal, vha, 0xb0db,

drivers/scsi/qla2xxx/qla_os.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4622,7 +4622,7 @@ qla2x00_free_fw_dump(struct qla_hw_data *ha)
		ha->flags.fce_enabled = 0;
		ha->eft = NULL;
		ha->eft_dma = 0;
		ha->fw_dumped = 0;
		ha->fw_dumped = false;
		ha->fw_dump_cap_flags = 0;
		ha->fw_dump_reading = 0;
		ha->fw_dump = NULL;