Commit 885d3e5b authored by Lucas De Marchi's avatar Lucas De Marchi
Browse files

drm/i915/display: fix comment on skl straps 



We are not checking for specific SKUs and feedback from HW team is that
it may not work since it was supposed to be fixed by the same time
straps stopped to be used. So, just update comment.

v2: Instead of removing the check, just update the comment since
feedback from HW team was that it actually may not work

Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200625001120.22810-3-lucas.demarchi@intel.com
parent d2063080

drivers/gpu/drm/i915/display/intel_display.c

+3 −2
Original line number Diff line number Diff line
@@ -11943,8 +11943,9 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) 


		/*

		 * Haswell uses DDI functions to detect digital outputs.

		 * On SKL pre-D0 the strap isn't connected, so we assume

		 * it's there.

		 * On SKL pre-D0 the strap isn't connected. Later SKUs may or

		 * may not have it - it was supposed to be fixed by the same

		 * time we stopped using straps. Assume it's there.

		 */

		found = intel_de_read(dev_priv, DDI_BUF_CTL(PORT_A)) & DDI_INIT_DISPLAY_DETECTED;

		/* WaIgnoreDDIAStrap: skl */