Commit 880d51c7 authored by Yoshihiro Shimoda's avatar Yoshihiro Shimoda Committed by Bjorn Helgaas
Browse files

PCI: endpoint: functions/pci-epf-test: Fix dma_chan direction 

In pci_epf_test_init_dma_chan() epf_test->dma_chan_rx is assigned from
dma_request_channel() with DMA_DEV_TO_MEM as filter.dma_mask.

However, in pci_epf_test_data_transfer() if the dir is DMA_DEV_TO_MEM,
epf->dma_chan_rx should be used but instead we are using
epf_test->dma_chan_tx.

Fix it.

Link: https://lore.kernel.org/r/20230412063447.2841177-1-yoshihiro.shimoda.uh@renesas.com


Fixes: 8353813c ("PCI: endpoint: Enable DMA tests for endpoints with DMA capabilities")
Tested-by: default avatarKunihiko Hayashi <hayashi.kunihiko@socionext.com>
Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
parent 4c50f933

drivers/pci/endpoint/functions/pci-epf-test.c

+1 −1
Original line number Diff line number Diff line
@@ -121,7 +121,7 @@ static int pci_epf_test_data_transfer(struct pci_epf_test *epf_test, 
				      size_t len, dma_addr_t dma_remote,

				      enum dma_transfer_direction dir)

{

	struct dma_chan *chan = (dir == DMA_DEV_TO_MEM) ?

	struct dma_chan *chan = (dir == DMA_MEM_TO_DEV) ?

				 epf_test->dma_chan_tx : epf_test->dma_chan_rx;

	dma_addr_t dma_local = (dir == DMA_MEM_TO_DEV) ? dma_src : dma_dst;

	enum dma_ctrl_flags flags = DMA_CTRL_ACK | DMA_PREP_INTERRUPT;