Commit 4c50f933 authored by Damien Le Moal's avatar Damien Le Moal Committed by Bjorn Helgaas
Browse files

misc: pci_endpoint_test: Simplify pci_endpoint_test_msi_irq() 

Simplify the code of pci_endpoint_test_msi_irq() by correctly using
booleans: remove the msix comparison to false as that variable is already a
boolean, and directly return the result of the comparison of the raised
interrupt number.

Link: https://lore.kernel.org/r/20230415023542.77601-18-dlemoal@kernel.org


Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lpieralisi@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarManivannan Sadhasivam <mani@kernel.org>
parent 168e6f62

drivers/misc/pci_endpoint_test.c

+4 −8
Original line number Diff line number Diff line
@@ -313,21 +313,17 @@ static bool pci_endpoint_test_msi_irq(struct pci_endpoint_test *test, 
	struct pci_dev *pdev = test->pdev;



	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_TYPE,

				 msix == false ? IRQ_TYPE_MSI :

				 IRQ_TYPE_MSIX);

				 msix ? IRQ_TYPE_MSIX : IRQ_TYPE_MSI);

	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_IRQ_NUMBER, msi_num);

	pci_endpoint_test_writel(test, PCI_ENDPOINT_TEST_COMMAND,

				 msix == false ? COMMAND_RAISE_MSI_IRQ :

				 COMMAND_RAISE_MSIX_IRQ);

				 msix ? COMMAND_RAISE_MSIX_IRQ :

				 COMMAND_RAISE_MSI_IRQ);

	val = wait_for_completion_timeout(&test->irq_raised,

					  msecs_to_jiffies(1000));

	if (!val)

		return false;



	if (pci_irq_vector(pdev, msi_num - 1) == test->last_irq)

		return true;



	return false;

	return pci_irq_vector(pdev, msi_num - 1) == test->last_irq;

}



static int pci_endpoint_test_validate_xfer_params(struct device *dev,