Commit 875fc315 authored Jul 19, 2021 by Vincent Li Committed by Andrii Nakryiko Jul 20, 2021

selftests, bpf: test_tc_tunnel.sh nc: Cannot use -p and -l



When run test_tc_tunnel.sh, it complains following error

ipip
encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
test basic connectivity
nc: cannot use -p and -l

nc man page has:

     -l  Listen for an incoming connection rather than initiating
         a connection to a remote host.Cannot be used together with
         any of the options -psxz. Additionally, any timeouts specified
         with the -w option are ignored.

Correct nc in server_listen().

Signed-off-by: Vincent Li <vincent.mc.li@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20210719223022.66681-1-vincent.mc.li@gmail.com

parent c39aa215

tools/testing/selftests/bpf/test_tc_tunnel.sh

+1 −1

Original line number	Diff line number	Diff line
		@@ -69,7 +69,7 @@ cleanup() {
		}

		server_listen() {
		ip netns exec "${ns2}" nc "${netcat_opt}" -l -p "${port}" > "${outfile}" &
		ip netns exec "${ns2}" nc "${netcat_opt}" -l "${port}" > "${outfile}" &
		server_pid=$!
		sleep 0.2
		}