Commit c39aa215 authored by John Fastabend's avatar John Fastabend Committed by Andrii Nakryiko
Browse files

bpf, selftests: Fix test_maps now that sockmap supports UDP 



UDP socket support was added recently so testing UDP insert failure is no
longer correct and causes test_maps failure. The fix is easy though, we
simply need to test that UDP is correctly added instead of blocked.

Fixes: 122e6c79 ("sock_map: Update sock type checks for UDP")
Reported-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Signed-off-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20210720184832.452430-1-john.fastabend@gmail.com
parent 08f71a1e

tools/testing/selftests/bpf/test_maps.c

+2 −2
Original line number Diff line number Diff line
@@ -764,8 +764,8 @@ static void test_sockmap(unsigned int tasks, void *data) 
	udp = socket(AF_INET, SOCK_DGRAM, 0);

	i = 0;

	err = bpf_map_update_elem(fd, &i, &udp, BPF_ANY);

	if (!err) {

		printf("Failed socket SOCK_DGRAM allowed '%i:%i'\n",

	if (err) {

		printf("Failed socket update SOCK_DGRAM '%i:%i'\n",

		       i, udp);

		goto out_sockmap;

	}