Commit 84da2a84 authored by Loic Poulain's avatar Loic Poulain Committed by Kalle Valo
Browse files

wcn36xx: del BA session on TX stop 



Deleting BA session was not correcly performed, causing communication
issues with APs that dynamically stop/start new BA sessions.

Signed-off-by: default avatarLoic Poulain <loic.poulain@linaro.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1611328304-1010-1-git-send-email-loic.poulain@linaro.org
parent 4b965be5

drivers/net/wireless/ath/wcn36xx/main.c

+2 −1
Original line number Diff line number Diff line
@@ -1140,7 +1140,7 @@ static int wcn36xx_ampdu_action(struct ieee80211_hw *hw, 
				       session);

		break;

	case IEEE80211_AMPDU_RX_STOP:

		wcn36xx_smd_del_ba(wcn, tid, get_sta_index(vif, sta_priv));

		wcn36xx_smd_del_ba(wcn, tid, 0, get_sta_index(vif, sta_priv));

		break;

	case IEEE80211_AMPDU_TX_START:

		spin_lock_bh(&sta_priv->ampdu_lock);
@@ -1164,6 +1164,7 @@ static int wcn36xx_ampdu_action(struct ieee80211_hw *hw, 
		sta_priv->ampdu_state[tid] = WCN36XX_AMPDU_NONE;

		spin_unlock_bh(&sta_priv->ampdu_lock);



		wcn36xx_smd_del_ba(wcn, tid, 1, get_sta_index(vif, sta_priv));

		ieee80211_stop_tx_ba_cb_irqsafe(vif, sta->addr, tid);

		break;

	default:

drivers/net/wireless/ath/wcn36xx/smd.c

+2 −2
Original line number Diff line number Diff line
@@ -2466,7 +2466,7 @@ int wcn36xx_smd_add_ba(struct wcn36xx *wcn, u8 session_id) 
	return ret;

}



int wcn36xx_smd_del_ba(struct wcn36xx *wcn, u16 tid, u8 sta_index)

int wcn36xx_smd_del_ba(struct wcn36xx *wcn, u16 tid, u8 direction, u8 sta_index)

{

	struct wcn36xx_hal_del_ba_req_msg msg_body;

	int ret;
@@ -2476,7 +2476,7 @@ int wcn36xx_smd_del_ba(struct wcn36xx *wcn, u16 tid, u8 sta_index) 


	msg_body.sta_index = sta_index;

	msg_body.tid = tid;

	msg_body.direction = 0;

	msg_body.direction = direction;

	PREPARE_HAL_BUF(wcn->hal_buf, msg_body);



	ret = wcn36xx_smd_send_and_wait(wcn, msg_body.header.len);

drivers/net/wireless/ath/wcn36xx/smd.h

+1 −1
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ int wcn36xx_smd_add_ba_session(struct wcn36xx *wcn, 
		u8 direction,

		u8 sta_index);

int wcn36xx_smd_add_ba(struct wcn36xx *wcn, u8 session_id);

int wcn36xx_smd_del_ba(struct wcn36xx *wcn, u16 tid, u8 sta_index);

int wcn36xx_smd_del_ba(struct wcn36xx *wcn, u16 tid, u8 direction, u8 sta_index);

int wcn36xx_smd_trigger_ba(struct wcn36xx *wcn, u8 sta_index, u16 tid, u8 session_id);



int wcn36xx_smd_update_cfg(struct wcn36xx *wcn, u32 cfg_id, u32 value);