Commit 4b965be5 authored by Karthikeyan Periyasamy's avatar Karthikeyan Periyasamy Committed by Kalle Valo
Browse files

ath11k: Update tx descriptor search index properly 



Tx descriptor search index field should be updated with hw peer id
and not by AST Hash as per the HW/FW recommendation. Incorrect search
index causes throughput degradation in all scenario for all the
platforms. so updated the search index field with hw peer id, which
is a common change applicable for all the platforms. Also no need of these
configuration for non station type. seen 10% throughput increase in WDS
traffic with this change.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01492-QCAHKSWPL_SILICONZ-1

Signed-off-by: default avatarKarthikeyan Periyasamy <periyasa@codeaurora.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1612410960-9120-1-git-send-email-periyasa@codeaurora.org
parent 7df28718

drivers/net/wireless/ath/ath11k/core.h

+1 −0
Original line number Diff line number Diff line
@@ -200,6 +200,7 @@ struct ath11k_vif { 
	u32 beacon_interval;

	u32 dtim_period;

	u16 ast_hash;

	u16 ast_idx;

	u16 tcl_metadata;

	u8 hal_addr_search_flags;

	u8 search_type;

drivers/net/wireless/ath/ath11k/dp_rx.c

+6 −2
Original line number Diff line number Diff line
@@ -1652,6 +1652,7 @@ void ath11k_dp_htt_htc_t2h_msg_handler(struct ath11k_base *ab, 
	u8 mac_addr[ETH_ALEN];

	u16 peer_mac_h16;

	u16 ast_hash;

	u16 hw_peer_id;



	ath11k_dbg(ab, ATH11K_DBG_DP_HTT, "dp_htt rx msg type :0x%0x\n", type);
@@ -1672,7 +1673,7 @@ void ath11k_dp_htt_htc_t2h_msg_handler(struct ath11k_base *ab, 
					 resp->peer_map_ev.info1);

		ath11k_dp_get_mac_addr(resp->peer_map_ev.mac_addr_l32,

				       peer_mac_h16, mac_addr);

		ath11k_peer_map_event(ab, vdev_id, peer_id, mac_addr, 0);

		ath11k_peer_map_event(ab, vdev_id, peer_id, mac_addr, 0, 0);

		break;

	case HTT_T2H_MSG_TYPE_PEER_MAP2:

		vdev_id = FIELD_GET(HTT_T2H_PEER_MAP_INFO_VDEV_ID,
@@ -1685,7 +1686,10 @@ void ath11k_dp_htt_htc_t2h_msg_handler(struct ath11k_base *ab, 
				       peer_mac_h16, mac_addr);

		ast_hash = FIELD_GET(HTT_T2H_PEER_MAP_INFO2_AST_HASH_VAL,

				     resp->peer_map_ev.info2);

		ath11k_peer_map_event(ab, vdev_id, peer_id, mac_addr, ast_hash);

		hw_peer_id = FIELD_GET(HTT_T2H_PEER_MAP_INFO1_HW_PEER_ID,

				       resp->peer_map_ev.info1);

		ath11k_peer_map_event(ab, vdev_id, peer_id, mac_addr, ast_hash,

				      hw_peer_id);

		break;

	case HTT_T2H_MSG_TYPE_PEER_UNMAP:

	case HTT_T2H_MSG_TYPE_PEER_UNMAP2:

drivers/net/wireless/ath/ath11k/dp_tx.c

+1 −0
Original line number Diff line number Diff line
@@ -165,6 +165,7 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *arvif, 
	ti.pkt_offset = 0;

	ti.lmac_id = ar->lmac_id;

	ti.bss_ast_hash = arvif->ast_hash;

	ti.bss_ast_idx = arvif->ast_idx;

	ti.dscp_tid_tbl_idx = 0;



	if (skb->ip_summed == CHECKSUM_PARTIAL &&

drivers/net/wireless/ath/ath11k/hal_tx.c

+2 −0
Original line number Diff line number Diff line
@@ -71,6 +71,8 @@ void ath11k_hal_tx_cmd_desc_setup(struct ath11k_base *ab, void *cmd, 
	tcl_cmd->info3 = FIELD_PREP(HAL_TCL_DATA_CMD_INFO3_DSCP_TID_TABLE_IDX,

				    ti->dscp_tid_tbl_idx) |

			 FIELD_PREP(HAL_TCL_DATA_CMD_INFO3_SEARCH_INDEX,

				    ti->bss_ast_idx) |

			 FIELD_PREP(HAL_TCL_DATA_CMD_INFO3_CACHE_SET_NUM,

				    ti->bss_ast_hash);

	tcl_cmd->info4 = 0;

}

drivers/net/wireless/ath/ath11k/hal_tx.h

+1 −0
Original line number Diff line number Diff line
@@ -29,6 +29,7 @@ struct hal_tx_info { 
	u32 flags1; /* %HAL_TCL_DATA_CMD_INFO2_ */

	u16 addr_search_flags; /* %HAL_TCL_DATA_CMD_INFO0_ADDR(X/Y)_ */

	u16 bss_ast_hash;

	u16 bss_ast_idx;

	u8 tid;

	u8 search_type; /* %HAL_TX_ADDR_SEARCH_ */

	u8 lmac_id;