Commit 82d78875 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

usb: musb: jz4740: Switch to use dev_err_probe() helper 



In the probe path, dev_err() can be replaced with dev_err_probe()
which will check if error code is -EPROBE_DEFER and prints the
error name. It also sets the defer probe reason which can be
checked later through debugfs. It's more simple in error path.

Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220927072616.913672-5-yangyingliang@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a806f67f

drivers/usb/musb/jz4740.c

+3 −7
Original line number Diff line number Diff line
@@ -105,7 +105,6 @@ static int jz4740_musb_init(struct musb *musb) 
		.driver_data = glue,

		.fwnode = dev_fwnode(dev),

	};

	int err;



	glue->musb = musb;
@@ -113,12 +112,9 @@ static int jz4740_musb_init(struct musb *musb) 
		musb->xceiv = devm_usb_get_phy_by_phandle(dev, "phys", 0);

	else

		musb->xceiv = devm_usb_get_phy(dev, USB_PHY_TYPE_USB2);

	if (IS_ERR(musb->xceiv)) {

		err = PTR_ERR(musb->xceiv);

		if (err != -EPROBE_DEFER)

			dev_err(dev, "No transceiver configured: %d\n", err);

		return err;

	}

	if (IS_ERR(musb->xceiv))

		return dev_err_probe(dev, PTR_ERR(musb->xceiv),

				     "No transceiver configured\n");



	glue->role_sw = usb_role_switch_register(dev, &role_sw_desc);

	if (IS_ERR(glue->role_sw)) {